sync: add AI review pipeline, parallel skill-files fetch, Redis cache improvements
- feat(review): add skill_reviews table, review API endpoints (pending/submit/stats), admin auth - perf: parallel file fetching in skill-files API (was sequential → timeout) - fix: handle Date serialization from Redis cache - fix: align curation batch scripts with current browseReadyFilter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
airano
142
apps/web/app/api/review/pending/route.ts
Normal file
142
apps/web/app/api/review/pending/route.ts
Normal file
@@ -0,0 +1,142 @@
|
||||
import { type NextRequest, NextResponse } from 'next/server';
|
||||
import { createDb, skillReviewQueries } from '@skillhub/db';
|
||||
import { requireAdmin } from '@/lib/admin-auth';
|
||||
import { withRateLimit, createRateLimitResponse, createRateLimitHeaders } from '@/lib/rate-limit';
|
||||
|
||||
export const maxDuration = 60; // seconds — queries 55K+ skills with owner-cap logic
|
||||
|
||||
const db = createDb();
|
||||
|
||||
/**
|
||||
* GET /api/review/pending
|
||||
* Returns a batch of skills ready for AI review.
|
||||
* Supports owner-capped batches for diversity and hybrid re-review/new-review mixing.
|
||||
*
|
||||
* Query params:
|
||||
* batch_size - number of skills to return (default 20, max 50)
|
||||
* offset - number of skills to skip for pagination (default 0)
|
||||
* min_quality - minimum quality_score (default 50)
|
||||
* security - security_status filter (default "pass")
|
||||
* priority - "re-review" to show needs-re-review first, "re-review-all" to include already ai-reviewed skills
|
||||
* owner_limit - max skills per github_owner in batch (default 0=unlimited, max 10)
|
||||
*/
|
||||
export async function GET(request: NextRequest) {
|
||||
// Rate limiting
|
||||
const rateLimitResult = await withRateLimit(request, 'anonymous');
|
||||
if (!rateLimitResult.allowed) {
|
||||
return createRateLimitResponse(rateLimitResult);
|
||||
}
|
||||
|
||||
// Admin check (supports API key auth via Authorization header)
|
||||
const adminCheck = await requireAdmin(request);
|
||||
if (!adminCheck.authorized) {
|
||||
return adminCheck.response;
|
||||
}
|
||||
|
||||
try {
|
||||
const { searchParams } = new URL(request.url);
|
||||
const batchSize = Math.min(
|
||||
Math.max(parseInt(searchParams.get('batch_size') ?? '20', 10) || 20, 1),
|
||||
50
|
||||
);
|
||||
const offset = Math.max(parseInt(searchParams.get('offset') ?? '0', 10) || 0, 0);
|
||||
const minQuality = parseInt(searchParams.get('min_quality') ?? '50', 10) || 50;
|
||||
const securityPass = searchParams.get('security') !== 'any';
|
||||
const priorityParam = searchParams.get('priority') ?? '';
|
||||
const priorityReReview = priorityParam === 're-review';
|
||||
const reReviewAll = priorityParam === 're-review-all';
|
||||
const ownerLimit = Math.min(
|
||||
Math.max(parseInt(searchParams.get('owner_limit') ?? '0', 10) || 0, 0),
|
||||
10
|
||||
);
|
||||
|
||||
// Run counts in parallel
|
||||
const [totalPending, reReviews] = await Promise.all([
|
||||
skillReviewQueries.countPending(db, { minQuality, securityPass }),
|
||||
skillReviewQueries.countReReviews(db),
|
||||
]);
|
||||
|
||||
// Re-review-all mode: skip hybrid mixing, just fetch all reviewable skills
|
||||
let batch: Array<{ id: string; githubOwner?: string; github_owner?: string; [key: string]: unknown }> = [];
|
||||
|
||||
if (reReviewAll) {
|
||||
const extraSlots = ownerLimit > 0 ? Math.min(batchSize, 10) : 0;
|
||||
const allBatch = await skillReviewQueries.getPending(db, {
|
||||
batchSize: batchSize + extraSlots,
|
||||
offset,
|
||||
minQuality,
|
||||
securityPass,
|
||||
reReviewAll: true,
|
||||
ownerLimit,
|
||||
}) as typeof batch;
|
||||
batch = [...allBatch].slice(0, batchSize);
|
||||
} else {
|
||||
// Normal mode: Hybrid batch — mix re-reviews (up to 5) with new reviews
|
||||
const reReviewSlots = Math.min(5, reReviews, batchSize);
|
||||
|
||||
if (reReviewSlots > 0 && !priorityReReview) {
|
||||
// Fetch re-reviews first (up to 5)
|
||||
const reReviewBatch = await skillReviewQueries.getPending(db, {
|
||||
batchSize: reReviewSlots,
|
||||
minQuality: 0, // re-reviews regardless of quality
|
||||
securityPass,
|
||||
priorityReReview: true,
|
||||
ownerLimit,
|
||||
});
|
||||
batch = [...reReviewBatch] as typeof batch;
|
||||
}
|
||||
|
||||
// Fill remaining slots with new reviews (or all slots if priority=re-review)
|
||||
const remainingSlots = batchSize - batch.length;
|
||||
if (remainingSlots > 0) {
|
||||
// Request extra to compensate for owner deduplication
|
||||
const extraSlots = ownerLimit > 0 ? Math.min(remainingSlots, 10) : 0;
|
||||
const newBatch = await skillReviewQueries.getPending(db, {
|
||||
batchSize: priorityReReview ? batchSize : (remainingSlots + extraSlots),
|
||||
offset,
|
||||
minQuality,
|
||||
securityPass,
|
||||
priorityReReview,
|
||||
ownerLimit,
|
||||
}) as typeof batch;
|
||||
|
||||
if (priorityReReview) {
|
||||
batch = [...newBatch];
|
||||
} else if (ownerLimit > 0 && batch.length > 0) {
|
||||
// Deduplicate owners: count per-owner across both batches
|
||||
const ownerCounts: Record<string, number> = {};
|
||||
for (const s of batch) {
|
||||
const owner = (s.githubOwner ?? s.github_owner ?? 'unknown') as string;
|
||||
ownerCounts[owner] = (ownerCounts[owner] || 0) + 1;
|
||||
}
|
||||
for (const s of newBatch) {
|
||||
const owner = (s.githubOwner ?? s.github_owner ?? 'unknown') as string;
|
||||
if ((ownerCounts[owner] || 0) >= ownerLimit) continue; // Skip — owner already at cap
|
||||
ownerCounts[owner] = (ownerCounts[owner] || 0) + 1;
|
||||
batch.push(s);
|
||||
if (batch.length >= batchSize) break;
|
||||
}
|
||||
} else {
|
||||
batch = [...batch, ...newBatch].slice(0, batchSize);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return NextResponse.json(
|
||||
{
|
||||
total_pending: totalPending,
|
||||
re_reviews: reReviews,
|
||||
batch,
|
||||
},
|
||||
{
|
||||
headers: createRateLimitHeaders(rateLimitResult),
|
||||
}
|
||||
);
|
||||
} catch (error) {
|
||||
console.error('[Review] Error fetching pending:', error);
|
||||
return NextResponse.json(
|
||||
{ error: 'Failed to fetch pending reviews' },
|
||||
{ status: 500 }
|
||||
);
|
||||
}
|
||||
}
|
||||
79
apps/web/app/api/review/stats/route.ts
Normal file
79
apps/web/app/api/review/stats/route.ts
Normal file
@@ -0,0 +1,79 @@
|
||||
import { type NextRequest, NextResponse } from 'next/server';
|
||||
import { createDb, skillReviewQueries } from '@skillhub/db';
|
||||
import { requireAdmin } from '@/lib/admin-auth';
|
||||
import { withRateLimit, createRateLimitResponse, createRateLimitHeaders } from '@/lib/rate-limit';
|
||||
import { getCached, setCache, cacheKeys, cacheTTL } from '@/lib/cache';
|
||||
|
||||
const db = createDb();
|
||||
|
||||
interface ReviewStatsData {
|
||||
unreviewed: number;
|
||||
auto_scored: number;
|
||||
ai_reviewed: number;
|
||||
verified: number;
|
||||
needs_re_review: number;
|
||||
total_reviews: number;
|
||||
}
|
||||
|
||||
/**
|
||||
* GET /api/review/stats
|
||||
* Returns review pipeline status statistics.
|
||||
*/
|
||||
export async function GET(request: NextRequest) {
|
||||
// Rate limiting
|
||||
const rateLimitResult = await withRateLimit(request, 'anonymous');
|
||||
if (!rateLimitResult.allowed) {
|
||||
return createRateLimitResponse(rateLimitResult);
|
||||
}
|
||||
|
||||
// Admin check (supports API key auth via Authorization header)
|
||||
const adminCheck = await requireAdmin(request);
|
||||
if (!adminCheck.authorized) {
|
||||
return adminCheck.response;
|
||||
}
|
||||
|
||||
try {
|
||||
// Check cache
|
||||
const cacheKey = cacheKeys.reviewStats();
|
||||
const cached = await getCached<ReviewStatsData>(cacheKey);
|
||||
if (cached) {
|
||||
return NextResponse.json(cached, {
|
||||
headers: {
|
||||
'X-Cache': 'HIT',
|
||||
...createRateLimitHeaders(rateLimitResult),
|
||||
},
|
||||
});
|
||||
}
|
||||
|
||||
// Run stats and total reviews count in parallel
|
||||
const [statusCounts, totalReviews] = await Promise.all([
|
||||
skillReviewQueries.getStats(db),
|
||||
skillReviewQueries.countTotalReviews(db),
|
||||
]);
|
||||
|
||||
const data: ReviewStatsData = {
|
||||
unreviewed: statusCounts['unreviewed'] ?? 0,
|
||||
auto_scored: statusCounts['auto-scored'] ?? 0,
|
||||
ai_reviewed: statusCounts['ai-reviewed'] ?? 0,
|
||||
verified: statusCounts['verified'] ?? 0,
|
||||
needs_re_review: statusCounts['needs-re-review'] ?? 0,
|
||||
total_reviews: totalReviews,
|
||||
};
|
||||
|
||||
// Cache for 60 seconds
|
||||
await setCache(cacheKey, data, cacheTTL.reviewStats);
|
||||
|
||||
return NextResponse.json(data, {
|
||||
headers: {
|
||||
'X-Cache': 'MISS',
|
||||
...createRateLimitHeaders(rateLimitResult),
|
||||
},
|
||||
});
|
||||
} catch (error) {
|
||||
console.error('[Review] Error fetching stats:', error);
|
||||
return NextResponse.json(
|
||||
{ error: 'Failed to fetch review stats' },
|
||||
{ status: 500 }
|
||||
);
|
||||
}
|
||||
}
|
||||
151
apps/web/app/api/review/submit/route.ts
Normal file
151
apps/web/app/api/review/submit/route.ts
Normal file
@@ -0,0 +1,151 @@
|
||||
import { type NextRequest, NextResponse } from 'next/server';
|
||||
import { createDb, skillReviewQueries } from '@skillhub/db';
|
||||
import { requireAdmin } from '@/lib/admin-auth';
|
||||
import { withRateLimit, createRateLimitResponse, createRateLimitHeaders } from '@/lib/rate-limit';
|
||||
|
||||
export const maxDuration = 60; // seconds — batch DB writes can be slow
|
||||
|
||||
const db = createDb();
|
||||
|
||||
interface ReviewItem {
|
||||
skill_id: string;
|
||||
ai_score?: number;
|
||||
instruction_quality?: number;
|
||||
description_precision?: number;
|
||||
usefulness?: number;
|
||||
technical_soundness?: number;
|
||||
review_notes?: string;
|
||||
suggested_categories?: string[];
|
||||
blog_worthy?: boolean;
|
||||
collection_candidate?: string | null;
|
||||
needs_improvement?: string | null;
|
||||
i18n_priority?: number;
|
||||
content_hash_at_review?: string;
|
||||
set_verified?: boolean;
|
||||
}
|
||||
|
||||
function validateReviews(body: unknown): { reviews: ReviewItem[] } | { error: string } {
|
||||
if (!body || typeof body !== 'object' || !('reviews' in body)) {
|
||||
return { error: 'Missing "reviews" array in request body' };
|
||||
}
|
||||
|
||||
const { reviews } = body as { reviews: unknown };
|
||||
if (!Array.isArray(reviews) || reviews.length === 0) {
|
||||
return { error: '"reviews" must be a non-empty array' };
|
||||
}
|
||||
if (reviews.length > 50) {
|
||||
return { error: '"reviews" array cannot exceed 50 items' };
|
||||
}
|
||||
|
||||
for (let i = 0; i < reviews.length; i++) {
|
||||
const r = reviews[i];
|
||||
if (!r || typeof r !== 'object') {
|
||||
return { error: `reviews[${i}] is not an object` };
|
||||
}
|
||||
const item = r as Record<string, unknown>;
|
||||
if (typeof item.skill_id !== 'string' || item.skill_id.length === 0) {
|
||||
return { error: `reviews[${i}].skill_id is required and must be a non-empty string` };
|
||||
}
|
||||
// Validate score fields (0-100 integers, optional)
|
||||
for (const field of ['ai_score', 'instruction_quality', 'description_precision', 'usefulness', 'technical_soundness']) {
|
||||
if (item[field] !== undefined && item[field] !== null) {
|
||||
if (typeof item[field] !== 'number' || !Number.isInteger(item[field]) || (item[field] as number) < 0 || (item[field] as number) > 100) {
|
||||
return { error: `reviews[${i}].${field} must be an integer 0-100` };
|
||||
}
|
||||
}
|
||||
}
|
||||
// Validate i18n_priority (0-2)
|
||||
if (item.i18n_priority !== undefined && item.i18n_priority !== null) {
|
||||
if (typeof item.i18n_priority !== 'number' || !Number.isInteger(item.i18n_priority) || item.i18n_priority < 0 || item.i18n_priority > 2) {
|
||||
return { error: `reviews[${i}].i18n_priority must be an integer 0-2` };
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return { reviews: reviews as ReviewItem[] };
|
||||
}
|
||||
|
||||
/**
|
||||
* POST /api/review/submit
|
||||
* Submit AI review results for a batch of skills.
|
||||
*/
|
||||
export async function POST(request: NextRequest) {
|
||||
// Rate limiting
|
||||
const rateLimitResult = await withRateLimit(request, 'anonymous');
|
||||
if (!rateLimitResult.allowed) {
|
||||
return createRateLimitResponse(rateLimitResult);
|
||||
}
|
||||
|
||||
// Admin check (supports API key auth via Authorization header)
|
||||
const adminCheck = await requireAdmin(request);
|
||||
if (!adminCheck.authorized) {
|
||||
return adminCheck.response;
|
||||
}
|
||||
|
||||
// Primary server check
|
||||
const isPrimary = process.env.IS_PRIMARY_SERVER !== 'false';
|
||||
if (!isPrimary) {
|
||||
return NextResponse.json(
|
||||
{ error: 'Write operations only on primary server' },
|
||||
{ status: 503 }
|
||||
);
|
||||
}
|
||||
|
||||
try {
|
||||
const body = await request.json();
|
||||
const result = validateReviews(body);
|
||||
if ('error' in result) {
|
||||
return NextResponse.json(
|
||||
{ error: result.error },
|
||||
{ status: 400 }
|
||||
);
|
||||
}
|
||||
|
||||
const { reviews } = result;
|
||||
|
||||
// Insert review rows
|
||||
const dbReviews = reviews.map((r) => ({
|
||||
skillId: r.skill_id,
|
||||
reviewer: 'claude-code' as const,
|
||||
aiScore: r.ai_score,
|
||||
instructionQuality: r.instruction_quality,
|
||||
descriptionPrecision: r.description_precision,
|
||||
usefulness: r.usefulness,
|
||||
technicalSoundness: r.technical_soundness,
|
||||
reviewNotes: r.review_notes,
|
||||
suggestedCategories: r.suggested_categories,
|
||||
blogWorthy: r.blog_worthy,
|
||||
collectionCandidate: r.collection_candidate ?? undefined,
|
||||
needsImprovement: r.needs_improvement ?? undefined,
|
||||
i18nPriority: r.i18n_priority,
|
||||
contentHashAtReview: r.content_hash_at_review,
|
||||
}));
|
||||
|
||||
await skillReviewQueries.createBatch(db, dbReviews);
|
||||
|
||||
// Update review_status on each skill
|
||||
let verifiedCount = 0;
|
||||
for (const r of reviews) {
|
||||
const newStatus = r.set_verified ? 'verified' : 'ai-reviewed';
|
||||
if (r.set_verified) verifiedCount++;
|
||||
|
||||
await skillReviewQueries.updateSkillReviewStatus(db, r.skill_id, newStatus);
|
||||
}
|
||||
|
||||
return NextResponse.json(
|
||||
{
|
||||
submitted: reviews.length,
|
||||
verified: verifiedCount,
|
||||
},
|
||||
{
|
||||
headers: createRateLimitHeaders(rateLimitResult),
|
||||
}
|
||||
);
|
||||
} catch (error) {
|
||||
console.error('[Review] Error submitting reviews:', error);
|
||||
return NextResponse.json(
|
||||
{ error: 'Failed to submit reviews' },
|
||||
{ status: 500 }
|
||||
);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user